Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all network data and messages deterministic #612

Merged
merged 6 commits into from
Dec 22, 2022
Merged

Make all network data and messages deterministic #612

merged 6 commits into from
Dec 22, 2022

Commits on Dec 21, 2022

  1. Fix headline height

    @HenrikJannsen
    HenrikJannsen committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    105dda4 View commit details
    Browse the repository at this point in the history

  2. Add delayed call to adjustMinHeight at init to trigger height adjustment

    @HenrikJannsen
    HenrikJannsen committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    7700b65 View commit details
    Browse the repository at this point in the history

  3. Add more info to registration.info text

    @HenrikJannsen
    HenrikJannsen committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    cd69c4c View commit details
    Browse the repository at this point in the history

  4. Reduce visibility

    @HenrikJannsen
    HenrikJannsen committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    de78308 View commit details
    Browse the repository at this point in the history

  5. Add deterministic sorting to Inventory as proof of work check compare… 

    …s byte arrays of payload and could fail otherwise
    @HenrikJannsen
    HenrikJannsen committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    cda9954 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2022

  1. Use lists instead of hashsets in data or messages to ensure that we h… 

    …ave deterministic behaviour.

The proof or work check compares the payload bytes and not deterministic sorting in collections would cause random failures.
We use generic sorting of the byte array of the serialized data.
    @HenrikJannsen
    HenrikJannsen committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    6a010b8 View commit details
    Browse the repository at this point in the history