Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate amount and price in create offer wizard #3057

Merged
merged 33 commits into from
Dec 19, 2024
Merged

Consolidate amount and price in create offer wizard #3057

merged 33 commits into from
Dec 19, 2024

Conversation

axpoems
Copy link
Contributor

@axpoems axpoems commented Dec 18, 2024

  • Simplify the create offer flow down to three steps plus review: steps amount & price are now merged into one.
  • Amount range selection is now done in the same input field, and slider has two pickers which use arrows instead of a knob. The latter has the added benefit of showing better the selected range and with better precision.
  • Add new component to show price (fixed and percentage) with the same design style as amount.

axpoems added 30 commits December 15, 2024 14:29
@axpoems
refactor: rename trade wizard direction and market package
aa496c6
@axpoems
Add new page to trade wizard consolidating amount and price
c899d6a
@axpoems
Use amount component inside amountAndPrice
67866b4
@axpoems
Add new amount model selection
9d93baa
@axpoems
Refactor: rename IsMinAmountEnabled to isRangeAmountEnabled
640f617
@axpoems
Add logic to new amount model selection buttons
a76fc47
@axpoems
Remove old toggle to switch between amount model
352a815
@axpoems
Remove old description texts
d78b85f
@axpoems
Improve AmountComponent
08947f0
@axpoems
More improvements in amount component
1fb01da
@axpoems
Refactor: split amount component into controller/model/view files
1605975
@axpoems
Improve amount component for the case of using range
2e5101a
@axpoems
Apply new design for amount ranges
f2c1b97
@axpoems
Several improvements
5e1e782
@axpoems
Add double slider to select amount range
25164eb
@axpoems
Improve slider labels
a603c6e
@axpoems
Fix amount limit info
d0bcb0f
@axpoems
Separate info and warnings section from main amount component
1d755f1
@axpoems
Add price component into amountAndPrice
cb7d9e1
@axpoems
Align amount and price input box design
ad669f8
@axpoems
Fix price text input font size selection
c0969c6
@axpoems
Set conversion price
b6e83a2
@axpoems
Use same input box for percentage price selection
d7ecb64
@axpoems
Adjust visibilities depending on whether is create or select offer
afd2c68
@axpoems
Fix overlapping issues
c1d1bf3
@axpoems
Open overlay from amountAtPrice
c605427
@axpoems
Fix range amount focus
3b3331f
@axpoems
Add style improvements
cba1fb4
@axpoems
Remove min/max labels in slider
4285633
@axpoems
Fix position of slider indicators
eb8147c
@axpoems axpoems merged commit 3e1a662 into bisq-network:main Dec 19, 2024
15 checks passed
@axpoems axpoems deleted the simplify-trade-wizard-2 branch December 19, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@axpoems