Add i18n module #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am aware that buildSrc is more for common tasks instead of sharing dependencies, but as we use it for logging as well I think it is convenient to repeat that pattern for application wide used dependencies. At least I don't see any downside... After some doubts I tend to be in favor of adding lombok as it improves productivity and reduces boilerplate code and thus increase readability. Java records are not flexible enough to replace all use cases for value objects, as well as other annotations are convenient as well.
This will hold translation strings. It is intended to use different files for different aspects of the application. If we can match the module boundaries is questionable. I assume that might be too fine grained. That module has no dependency to UI so can be used also for error logging in headless context, etc.
Merged
kaiwolfram
reviewed
Jun 12, 2021
Co-authored-by: Kai <[email protected]>
This changes a bit the behaviour in case of null values. We throw an IOException now, before it was returning null
ghost
approved these changes
Jun 14, 2021
Where do you get that? |
There are no lombok dependency version contraints defined in common-platform, so lombok-dependencies.gradle does not need to consume that platform. In the normal use case, lombok dependency version contraints would be defined in common-platform, and common-platform would be consumed by lombok-dependencies.gradle. However, this does not work for the gradle dependency configuration types `annotationProcessor` and `testAnnotationProcessor` (could be a Gradle bug). In this corner case, we do have to specify the version as @chimp1984 has done in lombok-dependencies.gradle.
It is odd, new git diff behaviour. If I add a newline to the end of a file, git complains: |
We only need logback.xml files in application level modules, not every module. And logback complains about finding multiple logback.xml files in the classpath.
ghubstan
reviewed
Jun 21, 2021
buildSrc/lombok-dependencies.gradle
Outdated
| @@ -0,0 +1,7 @@ | |||
| dependencies { | |||
| api platform(project(':platforms:common-platform')) | |||
There was a problem hiding this comment.
Commit 6edd97c removes api platform(project(':platforms:common-platform')) as per the commit's comment.
i18n/src/main/resources/logback.xml
Outdated
| @@ -0,0 +1,13 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
Commit 5db7a1a removes i18n/src/main/resources/logback.xml. See the commit's comment.
ghost
self-requested a review
|
ACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.