Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use typesafe Misq.conf in NetworkServiceConfigFactory #27

Merged
merged 5 commits into from
Jan 3, 2022
Merged

Use typesafe Misq.conf in NetworkServiceConfigFactory #27

merged 5 commits into from
Jan 3, 2022

Conversation

ghubstan
Copy link
Member

@ghubstan ghubstan commented Jan 2, 2022

  • Some TODO remarks are added to NetworkServiceConfigFactory.
  • Config variable names are verbose to disambiguate from non-typesafe Config types.

Based on main.

chimp1984
chimp1984 approved these changes Jan 3, 2022
View reviewed changes
Copy link
Contributor

@chimp1984 chimp1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@chimp1984 chimp1984 merged commit 2f1cd0e into bisq-network:main Jan 3, 2022
@ghubstan ghubstan deleted the 0-lightbend-network-config branch January 3, 2022 12:28
@ghubstan ghubstan mentioned this pull request Jan 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chimp1984 chimp1984 chimp1984 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghubstan @chimp1984