build-logic: Support m out of n signature verification #2460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Electrum all developers sign the binaries, but in Bitcoin Core a subset of its developers sign the binaries. Our existing signature verification code fails if not all developers have signed the binaries. This change enforces that all provided signatures are signed by its developers, i.e., if we have 20 hard-coded public keys and a binary has 10 signatures we ensure that the public keys of those 10 signatures belong to the hard-coded developers and all signatures are valid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Electrum all developers sign the binaries, but in Bitcoin Core a
subset of its developers sign the binaries. Our existing signature
verification code fails if not all developers have signed the
binaries.
This change enforces that all provided signatures are signed by its
developers, i.e., if we have 20 hard-coded public keys and a binary
has 10 signatures we ensure that the public keys of those 10 signatures
belong to the hard-coded developers and all signatures are valid.