Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @ExcludeForHash to inventory in InventoryRequest #2349

Conversation

HenrikJannsen
Copy link
Contributor

Implements #2346

When objects get an update we publish both the old version and the new one, where the new one is considered invalid for old nodes. The Invenotry contains all those data and would become itself invalid if we do not exclude the inventory from the hash creation for the pow check. Note that InventoryResponse is a direct message and its only the pow use case where the hash would cause issues.

@HenrikJannsen HenrikJannsen changed the title Add @ExcludeForHash to inventory. Add @ExcludeForHash to inventory Jul 1, 2024
@HenrikJannsen HenrikJannsen changed the title Add @ExcludeForHash to inventory Add @ExcludeForHash to inventory in InventoryRequest Jul 1, 2024
When objects get an update we publish both the old version and the new one, where the new one is considered invalid for old nodes. The Invenotry contains all those data and would become itself invalid if we do not exclude the inventory from the hash creation for the pow check.
Note that InventoryResponse is a direct message and its only the pow use case where the hash would cause issues.
@HenrikJannsen HenrikJannsen force-pushed the add-ExcludeForHash-annotation-to-inventory-in-InventoryResponse branch from 76c2048 to 8bdec08 Compare July 1, 2024 04:10
Copy link
Contributor

@djing-chan djing-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@djing-chan djing-chan merged commit 3764f23 into bisq-network:main Jul 1, 2024
16 checks passed
@HenrikJannsen HenrikJannsen deleted the add-ExcludeForHash-annotation-to-inventory-in-InventoryResponse branch July 1, 2024 05:12
@HenrikJannsen HenrikJannsen added this to the 2.1.0 milestone Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants