Get SOCKS5 port from Tor daemon #2122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't know the SOCKS5 port when we're using to a running Tor daemon. This change is needed to support external Tor instances. Ref: bisq-network#1894
alvasw
force-pushed
the
get_socks_port_from_tor_daemon
branch
from
b42ebc7 to
fbc95ac
Compare
djing-chan
approved these changes
Apr 27, 2024
| int port = Integer.parseInt(portString); | ||
| return Optional.of(port); | ||
| } catch (IOException e) { | ||
| return Optional.empty(); |
There was a problem hiding this comment.
Should we log an error or warning?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't know the SOCKS5 port when we're using to a running Tor daemon. This change is needed to support external Tor instances.
Ref: #1894