Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NullPointer exception caused by incorrect call of onViewDetached #1851

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Fix NullPointer exception caused by incorrect call of onViewDetached #1851

merged 1 commit into from
Mar 18, 2024

Conversation

HenrikJannsen
Copy link
Contributor

Bug reported by user:

e4

@HenrikJannsen
Ignore calls on onViewDetachedPrivate if view was not attached yet.
c84b928 
Add check if root scene is not null in case of overlays
@HenrikJannsen HenrikJannsen added the bug Something isn't working label Mar 18, 2024
@HenrikJannsen HenrikJannsen added this to the 2.0.2 milestone Mar 18, 2024
@HenrikJannsen HenrikJannsen mentioned this pull request Mar 18, 2024
Closed
alvasw
alvasw approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@alvasw alvasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alvasw alvasw merged commit 75aaea6 into bisq-network:main Mar 18, 2024
16 checks passed
@HenrikJannsen HenrikJannsen deleted the fix-incorrect-call-to-onViewDetached branch March 20, 2024 03:04
@HenrikJannsen HenrikJannsen mentioned this pull request Mar 30, 2024
Closed
@HenrikJannsen
Copy link
Contributor Author

Thanks for reporting. Addressed in #1955

@HenrikJannsen
Copy link
Contributor Author

Skærmbillede på 2024-03-29 18-44-49 ny Hi. I still get this error in v2.0.2 (pre-release) when I try to take an offer.

Which offer is it you want to take? I cannot reproduce it. Do you get it each time when taking that offer or only at certain cases?

@HenrikJannsen
Copy link
Contributor Author

Ah I found the issue. Its that the quote currency name in Market is "euro" instread of "Euro" because maker used spanish locale. We need to exclude that display strings from EqualsAndHashCode

@HenrikJannsen
Copy link
Contributor Author

Fixed here: #1960

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvasw alvasw alvasw approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
2.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@HenrikJannsen @alvasw