Remove redundant listener calls in data service [4] #1537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… verification at the handshake now
Make PrivateChats* MVC classes abstract Make all final classes final for helping to understand the complex inheritance structure
Channel sounds too much like a domain class and it was initially not very clear to me whats the purpose of that class.
Store last selected private channel
…nd entering view. This allows to deactivate listeners when we switch tabs. E.g. when changing a channel the newly selected channel would trigger the handler on the old view. This led to bugs that the newly added message in the new channel was published on the previously selected channel. It also avoids that the newly selected channel gets displayed its messages on the old transitioning view.
djing-chan
changed the title
…eded and just adds complexity. I leave still the changes with the more fine-grained transitions callbacks. It is now more clear why the bug with duplicated entries happened. It is fixed with a contains check before adding a new item, but @namloan should have a look if the delay at adding is still needed (was added as performance fix).
…ING. Apply that status when sending message started.
…adcast of the mailbox msg. Only after at least one successful broadcast completed we set the state to ADDED_TO_MAILBOX. Convert pending states at init to failed state.
Use that for successful states at message delivery
…the framework requires that persistence service classes are available when the persistence framework read in all data. As we do not want to pass the default node which is created later via a setter to PeerGroupService, it got refactored so that clients use node instead. This also reduced the usage of PeerGroupService where not needed. The peer group management could need more refactoring as it's a bit messy as it is now.
…licated listener calls have been redundant and caused issues on the clients (e.g. creating simultaneously 2 outbound connections)
djing-chan
force-pushed
the
remove-redundant-listener-calls-in-data-service
branch
from
d965c64 to
6caca44
Compare
djing-chan
deleted the
remove-redundant-listener-calls-in-data-service
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1536