Wallet: Support not encrypted wallets (#115) #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment, the wallet module raises a NullPointerException if the wallet is not encrypted. This shouldn't happen.
chimp1984
approved these changes
Mar 18, 2022
| String passphrase = model.walletPassphraseProperty.get(); | ||
| String passphraseValue = model.walletPassphraseProperty.get(); | ||
| Optional<String> passphrase = passphraseValue.isEmpty() ? Optional.empty() | ||
| : Optional.of(passphraseValue); | ||
| model.walletPassphraseProperty.setValue(""); // Wipe passphrase from memory |
There was a problem hiding this comment.
Actually to avoid that the passphrase sticks in memory (until GC cleans up) we should use a char array instead of a String and clear the array afterwards. But no need to do it now, just for hardening once we get more production ready.
This was referenced Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, the wallet module raises a NullPointerException if the
wallet is not encrypted. This shouldn't happen.