Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet Tests: Use random port for bitcoind regtest instance #101

Merged

Conversation

alvasw
Copy link
Contributor

@alvasw alvasw commented Feb 15, 2022

Get a free port and start the bitcoind regtest instances. Otherwise we could interfere with a running bitcoind regtest instance.

@alvasw alvasw marked this pull request as draft February 16, 2022 13:45
Get a free port and start the bitcoind regtest instances. Otherwise we
could interfere with a running bitcoind regtest instance.
@alvasw alvasw force-pushed the use_random_port_bitcoind_regtests branch from bd3460d to 866925f Compare February 23, 2022 16:38
@alvasw alvasw marked this pull request as ready for review February 23, 2022 16:40
Copy link
Contributor

@chimp1984 chimp1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@chimp1984 chimp1984 merged commit e5b90ef into bisq-network:main Feb 23, 2022
@alvasw alvasw deleted the use_random_port_bitcoind_regtests branch March 4, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants