-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish Bisq 2 libraries for re-use in Bisq-mobile #2951
Comments
@rodvar Can I assign that to you? |
@HenrikJannsen sure thing! |
starting work on this one |
Current status:
Modules to work out:
|
This was referenced Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We need to publish the Bisq 2 modules used in Bisq-mobile as jar libraries.
publish-all
convenience taskWe could use jitpack instead/additional to the local maven repository, but this will require verification.
I think local maven is at least during development easier and faster.
We could also consider to create a shadow jar to pack all into one jar. But I think having individual jars is probably better. If we package all we must avoid the non-android compatible modules like
java-se
, os-specific,
apps`,...When I used that approach in my POC branch I had issues with plugin
id("bisq.java-library")
as on android that caused a missing dependency to 'bisq::platform' which is not a java library and I did not manage to publish that. I guess it has to be recreated on the android project. By replacing theid("bisq.java-library")
plugin with:I could resolve that issue.
At the network module when adding the publish tasks (at
network-identity
) it caused problems on the network sub-projects (like tor). I did not manage to resolve those issues. Some Gradle experts will know for sure how to deal with that....The text was updated successfully, but these errors were encountered: