Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bisq 2 library dependencies #5

Closed
HenrikJannsen opened this issue Oct 24, 2024 · 4 comments
Closed

Add Bisq 2 library dependencies #5

HenrikJannsen opened this issue Oct 24, 2024 · 4 comments
Assignees
Labels
AndroidNode This issue is applicable ONLY for `androidNode` app

Comments

@HenrikJannsen
Copy link
Contributor

HenrikJannsen commented Oct 24, 2024

After bisq-network/bisq2#2951 is implemented we can resolve the Bisq 2 dependencies.

We should avoid duplicating complex gradle tasks already present in Bisq 2.
@alvasw is re-using Bisq 2 gradle tasks in Bisq 1, he might have suggestions how to do that best.

  • at the moment the bisq2 jars get published in the local maven repository only, so running the publishAll bisq2 gradle task is a must before tackling this one (related PR: Gradle task to publish dependencies for bisq mobile using mavenLocal bisq2#2965)
  • this is a breaking change for the CI setup as currently we don't have a publication to mavenCentral or other maven repos. Ideally this just be dealt in the context of this issue, otherwise it should comment the androidNode related code of the github workflow ci.yml file to avoid breaking builds.
@rodvar rodvar changed the title Add Bisq 2 library dependencies androidNode: Add Bisq 2 library dependencies Oct 24, 2024
@rodvar rodvar added the AndroidNode This issue is applicable ONLY for `androidNode` app label Oct 24, 2024
@rodvar rodvar changed the title androidNode: Add Bisq 2 library dependencies Add Bisq 2 library dependencies Oct 24, 2024
@rodvar rodvar self-assigned this Oct 24, 2024
@rodvar
Copy link
Collaborator

rodvar commented Nov 6, 2024

work on this can start now though not merged yet, leveraging this PR -> bisq-network/bisq2#2965

@rodvar
Copy link
Collaborator

rodvar commented Nov 6, 2024

the above PR is pretty much done, just need to either

  • remove androidNode from CI builds (cause it will fail being the bisq-core only maven-local publisheable) or
  • publish the bisq2 core libs to a maven repo like the ones used for some of our contributors libs

@rodvar
Copy link
Collaborator

rodvar commented Nov 8, 2024

we decided to remove androidNode from CI for now, I'll create an issue to fix this later down the road

@rodvar
Copy link
Collaborator

rodvar commented Nov 8, 2024

#29 merged

@rodvar rodvar closed this as completed Nov 8, 2024
@rodvar rodvar added this to the MVP (version 0.1.0) milestone Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AndroidNode This issue is applicable ONLY for `androidNode` app
Projects
None yet
Development

No branches or pull requests

2 participants