Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom errorLabel to MaterialTextField #1783

Closed
HenrikJannsen opened this issue Mar 13, 2024 · 0 comments · Fixed by #1992
Closed

Add custom errorLabel to MaterialTextField #1783

HenrikJannsen opened this issue Mar 13, 2024 · 0 comments · Fixed by #1992
Labels
good first issue Good for newcomers ui
Milestone
2.0.3

Comments

@HenrikJannsen
Copy link
Contributor

HenrikJannsen commented Mar 13, 2024 •
edited by alvasw
Loading

Add custom errorLabel to MaterialTextField and avoid reusing the helpLabel. Reusing the helpLabel would trigger an exception when the helpLabel is used in a binding.
@HenrikJannsen HenrikJannsen added this to the 2.0.3 milestone Mar 13, 2024
@HenrikJannsen HenrikJannsen added the good first issue Good for newcomers label Mar 18, 2024
This was referenced Mar 22, 2024
Closed
Closed
@alvasw alvasw changed the title Add custom errorLabel to MaterialTextField and not reuse helpLabel as it would cause an exception when binding at the helpLabel is used Add custom errorLabel to MaterialTextField Mar 23, 2024
@HenrikJannsen HenrikJannsen removed this from the 2.0.3 milestone Mar 28, 2024
ItoroD added a commit to ItoroD/bisq2 that referenced this issue Apr 3, 2024
@ItoroD
Merge branch 'Add-custom-errorLabel-to-MaterialTextField-and-not-reus…
198508b 
…e-helpLabel-as-it-would-cause-an-exception-when-binding-at-the-helpLabel-is-used-bisq-network#1783' of https://github.com/ItoroD/bisq2 into Add-custom-errorLabel-to-MaterialTextField-and-not-reuse-helpLabel-as-it-would-cause-an-exception-when-binding-at-the-helpLabel-is-used-bisq-network#1783

Merged changes
HenrikJannsen added a commit to HenrikJannsen/bisq2 that referenced this issue Apr 4, 2024
@HenrikJannsen
Merge remote-tracking branch 'ItoroD/Add-custom-errorLabel-to-Materia…
79f4754 
…lTextField-and-not-reuse-helpLabel-as-it-would-cause-an-exception-when-binding-at-the-helpLabel-is-used-#1783' into Add-custom-errorLabel-to-MaterialTextField-and-not-reuse-helpLabel-as-it-would-cause-an-exception-when-binding-at-the-helpLabel-is-used-bisq-network#1783

# Conflicts:
#	apps/desktop/desktop/src/main/java/bisq/desktop/components/controls/MaterialTextField.java
@HenrikJannsen HenrikJannsen mentioned this issue Apr 4, 2024
Merged
@HenrikJannsen HenrikJannsen added this to the 2.0.3 milestone Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers ui
Projects
None yet
Milestone
2.0.3
Development

Successfully merging a pull request may close this issue.

Add custom errorLabel to MaterialTextField (rebase of #1901) HenrikJannsen/bisq2
1 participant
@HenrikJannsen