Integrate new netlayer library #987
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Rosseel <[email protected]>
Signed-off-by: Mike Rosseel <[email protected]>
Signed-off-by: Mike Rosseel <[email protected]>
Conflicts: network/pom.xml network/src/main/java/io/bisq/network/p2p/network/TorNetworkNode.java
|
Just tested but localhost mode does not work. The relevant code in LocalhostNetworkNode is commented out. |
|
I clearly stated that cleanup was not yet done. |
|
Ah, sorry did not read the comment above... No idea yet but can look into it. |
Signed-off-by: Mike Rosseel <[email protected]>
Had to merge by hand because of the many changes in the new bisq structure. Also removed the 'default bridges' concept because it's discouraged to do that. Open issues: UI screen is still WIP, and bitcoinj SOCKS proxy error which makes that we can't connect to bitcoin nodes anymore. Signed-off-by: Mike Rosseel <[email protected]>
Signed-off-by: Mike Rosseel <[email protected]>
Signed-off-by: Mike Rosseel <[email protected]>
Signed-off-by: Mike Rosseel <[email protected]>
Signed-off-by: Mike Rosseel <[email protected]>
Replaced by the new netlayer library Signed-off-by: Mike Rosseel <[email protected]>
Signed-off-by: Mike Rosseel <[email protected]>
so far i understand your version is working bc another bug in the walletsetup where the Socks5MultiDiscovery is not used. so u use default dnsdiscover which leaks dns. that works only with SafeSocks 0. if using Socks5MultiDiscovery as is it should i only get 4 nodes form dns seeds. Signed-off-by: Mike Rosseel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first part of the integration of the new netlayer lib. (see issue #971)
These are the 3 parts:
Note: feel free to ignore this pull request, it's just open in case someone wants to test the new library.