API PR part 1/2, necessary changes to bisq-exchange for the API to work #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mrosseel
commented
Oct 13, 2017
mrosseel
commented
- updated dependencies are so they are consistent with dropwizard dependencies on those libraries. Not 100% necessary but always better.
- Extracting certain methods from GUI classes to other classes so they're available to the API.
…p all NetworkEnvelope classes
…ectedMailboxStorageEntry to StorageEntryHolder
# Conflicts: # core/src/main/java/io/bisq/core/trade/TradableList.java # core/src/main/java/io/bisq/core/trade/protocol/ProcessModel.java # core/src/test/java/io/bisq/core/util/ProtoBufferUtilitiesTest.java
…il, remove ProtoCoreUtil
# Conflicts: # common/src/main/java/io/bisq/common/storage/FileManager.java
# Conflicts: # common/src/main/java/io/bisq/common/storage/FileManager.java
…s, add try/catch in some places
This fixes an offer_make issue, but there is still one left. General cleanup of model files/parameters no longer needed. Remove offer_take savings_wallet param because it's always implied, external wallets are not yet supported. Signed-off-by: Mike Rosseel <[email protected]>
The JSON returned from trade_list was not correct, fixed by wrapping it in [ ] and not generating the ',' character for the last position. Signed-off-by: Mike Rosseel <[email protected]>
Using an environment variable called BISQ_API_PORT, it is now possible to override the default API port of 8080 to whichever available port desired. This enables running the API on a machine where port 8080 is occupied, it also enables running multiple Bisq instances side-by-side with their respective API's enabled. Signed-off-by: Mike Rosseel <[email protected]>
Use StringJoiner to sanely concatenate the list of trades. Signed-off-by: Mike Rosseel <[email protected]>
Balances were not calculated correctly, now they are by copying the code from GUI. This should be extracted in a common class in CORE, has been noted in a TODO. Given the splitting of api in a separate repository, I'm wary of adding extra changes to core/gui Signed-off-by: Mike Rosseel <[email protected]>
Branch did not compile due to missing checkin of the OfferUtil file. Signed-off-by: Mike Rosseel <[email protected]>
Remove slack notifications for now Signed-off-by: Mike Rosseel <[email protected]>
There was a duplicate entry in the pom, now removed. Signed-off-by: Mike Rosseel <[email protected]>
Instead of asking for a baseCurrency and a counterCurrency, the method now just takes the market_pair (as returned in market_pair method) and extracts the relevant currencies from that. Signed-off-by: Mike Rosseel <[email protected]>
Signed-off-by: Mike Rosseel <[email protected]>
Signed-off-by: Mike Rosseel <[email protected]>
The API module will be hosted in a separate repo, so it shouldn't be in this one. GUI module will reference the API artifact created by that other repo to allow the command-line switch to function on first checkout of the bisq project.
Conflicts: common/src/main/java/io/bisq/common/locale/LocaleUtil.java
The other changes in GUI, namely small refactoring to have the GUI and the API use the same methods to calculate things have been left in place.
Signed-off-by: Mike Rosseel <[email protected]>
|
That method is wrong: public Coin getMakerFee(boolean isCurrencyForMakerFeeBtc) { Need to be: Otherwise the isCurrencyForMakerFeeBtc param gets ignored. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.