Remove bouncy castle copy #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing Bisq, more maven way of doing
…jar are signed and can not be placed in shaded jar, copy them in a lib directory that will be use by shaded.jar classloader
…java policy in code, hopefully something we can removed soon when using jdk 9 (-dcrypto.policy=unlimited will be enough).
…ouncycastle:bcprov-jdk15on:1.52:jar:null:compile), now org.bouncycastle:bcprov-jdk15on:1.56:jar:null:compile with a different hash
|
Great thanks! The reflection hack u use seems a bit different to what I used int the past (which did not work reliably). So lets try it until we find problems. |
|
Btw: Better stick with Dev branch for PRs.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch show how to remove the need to tell the user to copy bouncy-castle in its local jre lib folder.
It consist of 2 commits which can be/are independent:
bouncy-castle jar are signed and can not be placed in shaded jar, maven will copy them in a lib directory that will be use by shaded.jar class-loader. This remove the need to copy the lib ib jre at the cost of shipping a lib folder at the same level of shaded.jar :-)
Setting unlimited cipher length: this commit can be controversial as it use reflection to hack the internal api of java BUT the code is only active for JDK 1.7/1.8 and nothing else. It was tested on windows, jdk 1.8.131. This avoid to copy the file jre policy zip file
Was is nice now is that you can git clone, mvn package and just java -jar shaded.jar to run without any effort on any os/ide