Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Utilities.getShortId and FluentProtocol.preCondition usage #7351

Conversation

thecockatiel
Copy link
Contributor

resolves #7346
resolves #7345

Verified

This commit was signed with the committer’s verified signature.
and the chunk is <= 8 characters long

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
Copy link
Collaborator

@HenrikJannsen HenrikJannsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alejandrogarcia83 alejandrogarcia83 merged commit c079407 into bisq-network:master Jan 15, 2025
3 checks passed
@alejandrogarcia83 alejandrogarcia83 added this to the v1.9.19 milestone Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug in Utilities.getShortId implementation? small bug in fluent protocol?
3 participants