Fix resource path URL decoding in tx validator tests and clean similar tests #7025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix resource loading in 'MakerTxValidatorSanityCheckTests', which breaks when the working directory has spaces in its absolute path, due to the fact that the test resource paths are URL encoded. (This pattern is already used to load resources in a few other tests, so there hopefully won't be a regression on Windows.)
Fix inspection warnings and other minor defects (unchecked casts, bad 'assert*' usage, unused assignments/declarations, missing null checks, object equality on enum instances, needless statement lambdas, missing final, redundant 'toString', needless visibility) in 'TxValidatorTest'. Also, uniformise and slightly tidy resource loading in other test classes, replacing 'Files.readAllBytes' with Java 11 'Files.readString' (which assumes UTF-8 as desired, instead of the default charset).
Now that 'mockito-junit-jupiter' has been added to the build test dependencies, we may replace the manual setup & tear down of a Mockito session with the 'MockitoExtension' JUnit 5 test extension, as the old Mockito JUnit 4 test runner was no longer available upon upgrading to Jupiter. This slightly simplifies the tests which use '@mock', '@SPY', etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent tests calling
MakerTxValidatorSanityCheckTests::getValidBtcMakerFeeMempoolJsonResponseStringfrom failing when running the build from a working directory with spaces in its absolute path, due to the fact that the test resource paths returned byClass::getResourceare URL encoded.Also do some minor tidying of other tests which load resources, and replace manual
MockitoSessionsetup & tear down in tests which still do that, now thatmockito-junit-jupiterhas been added to the build dependencies.