Wise: fix account summary and add copy icon to form. #6986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Copy icon added to Pix account form also:
|
alvasw
suggested changes
Jan 20, 2024
|
Done. |
alvasw
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
ACK
Perfect! Thank you so much!
Test Setup
- Created Pix and Wise accounts on v1.9.14 on Alice's and Bob's Bisq instance
- Created Pix and Wise accounts on this PR on Alice's and Bob's Bisq instance
Trades (For Pix and Wise)
- Between old accounts
- Checked trade details screen
- Tested copy button
- Between new accounts
- Checked trade details screen
- Tested copy button
- Between old and new accounts
- Checked trade details screen
- Tested copy button
|
@yonson2023 Thank you for opening this PR. I can't merge your PR before your commits are signed. For more information see: https://github.com/bisq-network/bisq/blob/master/CONTRIBUTING.md#sign-your-commits-with-gpg |
Add copy icon to Pix form holder name field. Prompt for holder name if empty. Optimize form layout.
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix review issues raised by @alvasw. Closes #6983 Closes #6984 Closes #6985