Improve flow in create/take offer process. #6848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating or taking an offer the user gets the choice to fund the trade from an external wallet for potentially better privacy (avoid coin merge if inputs from ext. wallet are kept separated). From feedback it seems that most users are not using that option and then they need to do that extra click on the "Fund from internal Bisq wallet" button. We offer a way to avoid that extra step if the user chooses to use the internal wallet. We show at the first time a popup with background info why funding from an external wallet could improve privacy and if the user prefers to not use that to give them an option to skip that step in future. In the settings we could add a toggle to re-enable it again. The review screen can be skipped if user chooses this feature, leading to data entry > confirm rather than data entry > fund > review > confirm.
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Cuts make/take offer process from 4 screens to 2 by opting to fund from Bisq wallet.
Requested by @HenrikJannsen #6824.
When creating or taking an offer the user gets the choice to fund the trade from an external wallet for potentially better privacy (avoid coin merge if inputs from ext. wallet are kept separated). From feedback it seems that most users are not using that option and then they need to do that extra click on the "Fund from internal Bisq wallet" button.
We offer a way to avoid that extra step if the user chooses to use the internal wallet. We show at the first time a popup which give them an option to prefer funding from Bisq wallet in future, with background info why funding from an external wallet could improve privacy. In the settings we add a toggle to enable/disable the feature. The funding and review screens are skipped if user chooses this feature, leading to
data entry > confirm(2 clicks) rather thandata entry > fund > review > confirm(4 clicks).(Note that if the Bisq wallet lacks sufficient funds, it will revert to prompting the user to fund the trade as before).