Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve build-time: Lazily apply gRPC plugin #6771

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Improve build-time: Lazily apply gRPC plugin #6771

merged 2 commits into from
Jul 17, 2023

Conversation

alvasw
Copy link
Contributor

@alvasw alvasw commented Jul 17, 2023

alejandrogarcia83

This comment was marked as outdated.

Sign in to view

@alvasw alvasw dismissed alejandrogarcia83’s stale review July 17, 2023 18:12

The merge-base changed after approval.

alejandrogarcia83
alejandrogarcia83 previously approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alvasw alvasw dismissed alejandrogarcia83’s stale review July 17, 2023 18:19

The merge-base changed after approval.

gabernard
gabernard approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@gabernard gabernard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@gabernard gabernard merged commit 31d0241 into bisq-network:master Jul 17, 2023
@alvasw alvasw mentioned this pull request Aug 18, 2023
Closed
@alejandrogarcia83 alejandrogarcia83 added this to the v1.9.13 milestone Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabernard gabernard gabernard approved these changes

@alejandrogarcia83 alejandrogarcia83 alejandrogarcia83 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.9.14
Development

Successfully merging this pull request may close these issues.
3 participants
@alvasw @gabernard @alejandrogarcia83