Make processing burningman accounting data optional #6644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: HenrikJannsen <[email protected]>
Add popup when selecting a burningman to ask for enabling processing Signed-off-by: HenrikJannsen <[email protected]>
… set. Signed-off-by: HenrikJannsen <[email protected]>
…t is in progress. We use a postfix to the header title and not a busy animation, as the busy animation is quite CPU intense. Signed-off-by: HenrikJannsen <[email protected]>
HenrikJannsen
deleted the
make_processing_burningman_accounting_data_optional
branch
ghost
reviewed
Jun 30, 2023
| @@ -160,6 +164,10 @@ public void onParseBlockChainComplete() { | |||
|
|
|||
| @Override | |||
| public void addListeners() { | |||
| if (!preferences.isProcessBurningManAccountingData()) { | |||
There was a problem hiding this comment.
A problem (bug) here is it prevents seednodes from processing Accounting data! 😱
There was a problem hiding this comment.
Saw it too late, but seem its fixed by @jmacxx already
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Processing burningman accounting data an take quite some time and CPU. As most Bisq users are likely not interested in those data, this PR deactivates it by default.
Users who are interested in that data can enable it in the settings at the DAO section (requires restart) or when selecting a BM in the table they get a popup to enable it.
If not enabled the UI shows a "(accounting data not updated)" post fix to the "Selected contributor" header. The displayed data is the one from the last update or the one shipped by the release.
If enabled and still processing data we show a "(still processing data...)" post fix to the "Selected contributor" header.
We do not use a busy animation as this is quite CPU intense.
Once all data is processed the post fix is removed.