Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing JUnit4 with JUnit5 Jupiter #6619

Merged
merged 1 commit into from
May 7, 2023
Merged

Replacing JUnit4 with JUnit5 Jupiter #6619

merged 1 commit into from
May 7, 2023

Conversation

napoly
Copy link
Contributor

@napoly napoly commented Mar 27, 2023 •
edited
Loading

Removing JUnit 4 dependencies and upgrading Hamcrest.

@boring-cyborg boring-cyborg bot added in:altcoins is:no-priority PR or issue marked with this label is not up for compensation right now labels Mar 27, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 27, 2023

Thanks for opening this pull request!

Please check out our contributor checklist and check if Travis or Codacy found any issues with your PR. Also make sure your commits are signed, and that you applied Bisq's code style and formatting.

A maintainer will add an is:priority label to your PR if it is up for compensation. Please see our Bisq Q1 2020 Update post for more details.

@napoly napoly force-pushed the upgrade_junit4_to_junit5_jupiter branch 2 times, most recently from c3b618e to acd8e44 Compare March 27, 2023 14:55
@napoly napoly changed the title Replacing JUnit 4 with JUnit5 Jupiter Replacing JUnit4 with JUnit5 Jupiter Mar 27, 2023
@napoly napoly force-pushed the upgrade_junit4_to_junit5_jupiter branch 3 times, most recently from 94019db to 468b2dd Compare April 4, 2023 16:57
@napoly napoly force-pushed the upgrade_junit4_to_junit5_jupiter branch from 468b2dd to 5bbbf41 Compare April 9, 2023 08:23
@napoly napoly force-pushed the upgrade_junit4_to_junit5_jupiter branch from 5bbbf41 to e19ffe2 Compare May 4, 2023 18:09
alvasw
alvasw approved these changes May 7, 2023
View reviewed changes
Copy link
Contributor

@alvasw alvasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

alejandrogarcia83
alejandrogarcia83 approved these changes May 7, 2023
View reviewed changes
Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alejandrogarcia83 alejandrogarcia83 merged commit b907769 into bisq-network:master May 7, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented May 7, 2023

Awesome work, congrats on your first merged pull request!

@alejandrogarcia83
Copy link
Contributor

Congrats to your first merged PR in Bisq!

@napoly napoly deleted the upgrade_junit4_to_junit5_jupiter branch May 7, 2023 17:05
@napoly
Copy link
Contributor Author

napoly commented May 7, 2023

thank you !!!

alvasw added a commit to alvasw/bisq that referenced this pull request May 9, 2023
@alvasw
core: Fix broken PriceTest.testParse test
734650d 
Relates to bisq-network#6619
alvasw added a commit to alvasw/bisq that referenced this pull request May 10, 2023
@alvasw
core: Fix broken CoinUtilTest.testGetAdjustedAmount
6e1bc37 
Relates to bisq-network#6619
alvasw added a commit to alvasw/bisq that referenced this pull request May 10, 2023
@alvasw
Fix broken P2PDataStoragePersistableNetworkPayloadTest
5f655f6 
Relates to bisq-network#6619
alvasw added a commit to alvasw/bisq that referenced this pull request May 10, 2023
@alvasw
Fix broken ProtectedStorageEntryTest
ad570ab 
Relates to bisq-network#6619
alvasw added a commit to alvasw/bisq that referenced this pull request May 10, 2023
@alvasw
Fix broken ProtectedStorageEntryTest
d12bd1f 
Relates to bisq-network#6619
alvasw added a commit to alvasw/bisq that referenced this pull request May 10, 2023
@alvasw
Re-enable all tests
d3e1be9 
Relates to bisq-network#6619
This was referenced May 10, 2023
Merged
Merged
Merged
alvasw added a commit to alvasw/bisq that referenced this pull request May 10, 2023
@alvasw
Fix broken ProtectedStorageEntryTest
787da04 
Relates to bisq-network#6619
@alvasw alvasw mentioned this pull request May 10, 2023
Merged
alvasw added a commit to alvasw/bisq that referenced this pull request May 10, 2023
@alvasw
core: Fix broken PriceTest.testParse test
dbcb2e7 
Relates to bisq-network#6619
alvasw added a commit to alvasw/bisq that referenced this pull request May 10, 2023
@alvasw
core: Fix broken CoinUtilTest.testGetAdjustedAmount
2ae6fab 
Relates to bisq-network#6619
alvasw added a commit to alvasw/bisq that referenced this pull request May 10, 2023
@alvasw
Fix broken P2PDataStoragePersistableNetworkPayloadTest
0a1a276 
Relates to bisq-network#6619
alvasw added a commit to alvasw/bisq that referenced this pull request May 10, 2023
@alvasw
Fix broken ProtectedStorageEntryTest
f51266c 
Relates to bisq-network#6619
alvasw added a commit to alvasw/bisq that referenced this pull request May 10, 2023
@alvasw
Re-enable all tests
5e469dd 
Relates to bisq-network#6619
@alvasw alvasw mentioned this pull request May 10, 2023
Merged
alvasw added a commit to alvasw/bisq that referenced this pull request May 13, 2023
@alvasw
core: Fix broken CoinUtilTest.testGetAdjustedAmount
e94da0d 
Relates to bisq-network#6619
alvasw added a commit to alvasw/bisq that referenced this pull request May 13, 2023
@alvasw
Re-enable all tests
ec7755a 
Relates to bisq-network#6619
@alejandrogarcia83 alejandrogarcia83 added this to the v1.9.11 milestone Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alejandrogarcia83 alejandrogarcia83 alejandrogarcia83 approved these changes

@alvasw alvasw alvasw approved these changes

Assignees
No one assigned
Labels
in:altcoins is:no-priority PR or issue marked with this label is not up for compensation right now
Projects
None yet
Milestone
v1.9.11
Development

Successfully merging this pull request may close these issues.
3 participants
@napoly @alejandrogarcia83 @alvasw