Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connection: Close protoOutputStream before closing socket #6542

Merged
merged 1 commit into from
Jan 28, 2023
Merged

Connection: Close protoOutputStream before closing socket #6542

merged 1 commit into from
Jan 28, 2023

Conversation

alvasw
Copy link
Contributor

@alvasw alvasw commented Jan 27, 2023

The protoOutputStream depends on the sockets OutputStream. Closing the socket before closing the protoOutputStream will always trigger an IOException.

@alvasw
Connection: Close protoOutputStream before closing socket
e593adb 
The protoOutputStream depends on the sockets OutputStream. Closing the
socket before closing the protoOutputStream will always trigger an
IOException.
HenrikJannsen
HenrikJannsen approved these changes Jan 28, 2023
View reviewed changes
Copy link
Collaborator

@HenrikJannsen HenrikJannsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

alejandrogarcia83
alejandrogarcia83 approved these changes Jan 28, 2023
View reviewed changes
Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alejandrogarcia83 alejandrogarcia83 merged commit b87de3d into bisq-network:master Jan 28, 2023
@alejandrogarcia83 alejandrogarcia83 added this to the v1.9.10 milestone Jan 28, 2023
@alvasw alvasw deleted the connection_close_proto_outputstream_before_socket branch February 6, 2023 12:04
@alvasw alvasw mentioned this pull request Feb 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alejandrogarcia83 alejandrogarcia83 alejandrogarcia83 approved these changes

@HenrikJannsen HenrikJannsen HenrikJannsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.9.10
Development

Successfully merging this pull request may close these issues.
3 participants
@alvasw @HenrikJannsen @alejandrogarcia83