Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UI filter box. #6525

Merged
merged 1 commit into from Jan 21, 2023
Merged

Fix UI filter box. #6525

merged 1 commit into from Jan 21, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jan 17, 2023

Fixes #6475

As described in the issue, the problem being fixed is: The row count number (summary of items being shown) is not updated while using the filter, only after changing tabs. It should always reflect the number of records shown.

Select HISTORY tab and remember the number. Example 100
Apply a Filter and count the elements manually. Example 2
Change to the MY OPEN OFFERS tab
Change back to the HISTORY tab and check the number again.

In our example the number is 2 and not 100. So the number changed to reflect the applied filter, but it is applied only after changing tabs.

Applies to:

  • Funds/ Transactions, Locked, Reserved.
  • Portfolio/ Open Offers, Unconfirmed Bisq Swaps, History, Failed.

@alejandrogarcia83 alejandrogarcia83 added this to the v1.9.10 milestone Jan 21, 2023
alejandrogarcia83
alejandrogarcia83 approved these changes Jan 21, 2023
View reviewed changes
Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK - Tested it on Mainnet
Congrats to your first merged PR in Bisq!

@alejandrogarcia83 alejandrogarcia83 merged commit df39805 into bisq-network:master Jan 21, 2023
HenrikJannsen
HenrikJannsen reviewed Jan 26, 2023
View reviewed changes
desktop/src/main/java/bisq/desktop/main/funds/reserved/ReservedView.java
openOfferManager.getObservableList().addListener(openOfferListChangeListener);
tradeManager.getObservableList().addListener(tradeListChangeListener);
sortedList.comparatorProperty().bind(tableView.comparatorProperty());
tableView.setItems(sortedList);
updateList();
filterBox.initializeWithCallback(filteredList, tableView, () ->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yonson2023 Why is that not inside initialize()?

This was referenced Mar 8, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.9.10
Development

Successfully merging this pull request may close these issues.

Status bar not updated
2 participants
@HenrikJannsen @alejandrogarcia83