Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid multiple popups #6509

Conversation

HenrikJannsen
Copy link
Collaborator

Avoid that at repeated onDaoStateHashesChanged calls that we show multiple popups.

HenrikJannsen added a commit to HenrikJannsen/bisq that referenced this pull request Jan 7, 2023
Signed-off-by: HenrikJannsen <[email protected]>
@alejandrogarcia83 alejandrogarcia83 added this to the v1.9.9 milestone Jan 7, 2023
Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alejandrogarcia83 alejandrogarcia83 merged commit f4c679d into bisq-network:master Jan 7, 2023
@HenrikJannsen HenrikJannsen deleted the avoid_repeated_dao_not_in_sync_popup_display branch January 23, 2023 02:19
Copy link

@Chelo5479 Chelo5479 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is void now

@HenrikJannsen
Copy link
Collaborator Author

@Chelo5479 Did your review find issues? Still good to report is there is any to fix in a new PR...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants