Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seednode improvements for monitoring #6478

Merged
merged 16 commits into from
Dec 29, 2022

Conversation

HenrikJannsen
Copy link
Collaborator

@HenrikJannsen HenrikJannsen commented Dec 20, 2022

No description provided.

@HenrikJannsen HenrikJannsen changed the title Seednodes Seednode improvements for monitoring Dec 20, 2022
…error instead calling the uncaughtExceptionHandler

Signed-off-by: HenrikJannsen <[email protected]>
Add try/catch to handle RejectedExecutionException

Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
The broadcasting consumes most of the threads but has lower priority than other messages being sent.
By separating that thread pool from the common sendMessage executor we can reduce the risk that a burst of
broadcasts exhausts the thread pool and might drop send message tasks.

Signed-off-by: HenrikJannsen <[email protected]>
Only log lostAllConnections after numOnConnections > 2 to avoid logs at startup

Signed-off-by: HenrikJannsen <[email protected]>
Remove Unspecified and use optional instead.
Add reporting for data requests and hash requests.
Report commit hash only if present.
Report messages only if an enum entry is present.

Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
@HenrikJannsen HenrikJannsen marked this pull request as ready for review December 27, 2022 22:55
…BurningManService.isActivated() is false.

This allows us to run the seed nodes already in BM mode before activation

Signed-off-by: HenrikJannsen <[email protected]>
ghost
ghost previously approved these changes Dec 28, 2022
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

One seed node using the ExportJsonFilesService had RejectedExecutionExceptions as before we had only permitted a thread pool queue capacity of 1.

Signed-off-by: HenrikJannsen <[email protected]>
Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alejandrogarcia83 alejandrogarcia83 merged commit 2298d12 into bisq-network:master Dec 29, 2022
@alejandrogarcia83 alejandrogarcia83 modified the milestones: v1.9.9, v1.9.10 Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants