-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seednode improvements for monitoring #6478
Merged
alejandrogarcia83
merged 16 commits into
bisq-network:master
from
HenrikJannsen:seednodes
Dec 29, 2022
Merged
Seednode improvements for monitoring #6478
alejandrogarcia83
merged 16 commits into
bisq-network:master
from
HenrikJannsen:seednodes
Dec 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…error instead calling the uncaughtExceptionHandler Signed-off-by: HenrikJannsen <[email protected]>
Add try/catch to handle RejectedExecutionException Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
The broadcasting consumes most of the threads but has lower priority than other messages being sent. By separating that thread pool from the common sendMessage executor we can reduce the risk that a burst of broadcasts exhausts the thread pool and might drop send message tasks. Signed-off-by: HenrikJannsen <[email protected]>
Only log lostAllConnections after numOnConnections > 2 to avoid logs at startup Signed-off-by: HenrikJannsen <[email protected]>
…are sent. Signed-off-by: HenrikJannsen <[email protected]>
Remove Unspecified and use optional instead. Add reporting for data requests and hash requests. Report commit hash only if present. Report messages only if an enum entry is present. Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
HenrikJannsen
force-pushed
the
seednodes
branch
from
December 27, 2022 22:54
39c59af
to
9a31606
Compare
…BurningManService.isActivated() is false. This allows us to run the seed nodes already in BM mode before activation Signed-off-by: HenrikJannsen <[email protected]>
ghost
previously approved these changes
Dec 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
One seed node using the ExportJsonFilesService had RejectedExecutionExceptions as before we had only permitted a thread pool queue capacity of 1. Signed-off-by: HenrikJannsen <[email protected]>
alejandrogarcia83
approved these changes
Dec 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.