Apply code review suggestions to seednode changes #6454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove setter of key. Signed-off-by: HenrikJannsen <[email protected]>
Use executor at httpClient builder. Use httpClient.sendAsync. Add keep-alive header. Add RejectedExecutionHandler. Signed-off-by: HenrikJannsen <[email protected]>
I want to avoid to risk changes with not calling error handlers/listeners in those cases as not 100% sure if that could have unintended effects. Signed-off-by: HenrikJannsen <[email protected]>
…porting Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
|
@HenrikJannsen Should this be included in v1.9.7? |
alvasw
approved these changes
Dec 12, 2022
There was a problem hiding this comment.
utACK
Hi @HenrikJannsen !
I looked over your changes and looks good to me. I saw you moved the ReportingItems to the seednode package. Good job!
ripcurlx
approved these changes
Dec 12, 2022
HenrikJannsen
deleted the
apply_code_review_suggestions_to_seednode_changes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply suggestions from #6432 (comment)