Enforce gradle dependency verification #6443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following artifacts failed verification: - javafx-base-16-linux.jar (org.openjfx:javafx-base:16) from repository MavenRepo - javafx-controls-16-linux.jar (org.openjfx:javafx-controls:16) from repository MavenRepo - javafx-fxml-16-linux.jar (org.openjfx:javafx-fxml:16) from repository MavenRepo - javafx-graphics-16-linux.jar (org.openjfx:javafx-graphics:16) from repository MavenRepo - protoc-3.19.1-linux-x86_64.exe (com.google.protobuf:protoc:3.19.1) from repository MavenRepo - protoc-gen-grpc-java-1.42.1-linux-x86_64.exe (io.grpc:protoc-gen-grpc-java:1.42.1) from repository MavenRepo - jackson-base-2.12.1.pom - protoc-3.19.1-windows-x86_64.exe - protoc-gen-grpc-java-1.42.1-windows-x86_64.exe - junit-bom-5.7.0.pom - javafx-base-16-win.jar - javafx-controls-16-win.jar - javafx-fxml-16-win.jar - javafx-graphics-16-win.jar
The built-in Gradle dependency verification XML writer does not find all our libraries for some unknown reason. I had to compute and add multiple hashes manually. It seems like it is OS related and the CI output helped to fix the problem. The console output makes it hard to fix issues because we cannot access the generated HTML file. This change reenables the verbose failure report.
We had some issues with the Gradle Dependency Verification and nobody noticed it because it was not enforced by Gradle. Supply chain attack are sadly a real threat that should not be underestimated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had some issues with the Gradle Dependency Verification and nobody noticed it because it was not enforced by Gradle. Supply chain attack are sadly a real threat that should not be underestimated.