Improve dispute validation #6404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
…efundManager Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
We verify later the contract hash in disputes and that would fail otherwise.
…deAddress methods Signed-off-by: HenrikJannsen <[email protected]>
It is allowed that there are change outputs, for instance if taker does not take full trade amount, there is a change output for maker. Signed-off-by: HenrikJannsen <[email protected]>
ghost
reviewed
Nov 3, 2022
core/src/main/java/bisq/core/support/dispute/refund/RefundManager.java
Outdated
Show resolved
Hide resolved
It is allowed that there are change outputs, for instance if taker does not take full trade amount, there is a change output for maker. Signed-off-by: HenrikJannsen <[email protected]>
ghost
reviewed
Nov 3, 2022
desktop/src/main/java/bisq/desktop/main/overlays/windows/DisputeSummaryWindow.java
Outdated
Show resolved
Hide resolved
Signed-off-by: HenrikJannsen <[email protected]>
|
@sqrrm Would you be available for a review as well? |
|
@sqrrm ☝️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains more validation for dispute data and further preparations for bisq-network/proposals#390 implementation