Code

Refactor dispute validation#6402

Code

Merged

sqrrm merged 17 commits intobisq-network:masterbisq-network/bisq:masterfrom HenrikJannsen:refactor-dispute-validationHenrikJannsen/bisq:refactor-dispute-validationCopy head branch name to clipboardNov 3, 2022

+342-319

Commits

Commits on Nov 3, 2022

• Reformat code and reorg imports

  Show description for 43fb0cc
  HenrikJannsen

  committed
  43fb0cc

  Copy full SHA for 43fb0cc

• Add /.run to gitignore

  Show description for d7deb16
  HenrikJannsen

  committed
  d7deb16

  Copy full SHA for d7deb16

• Add DisputeValidation class for validation methods and exceptions of the dispute domain.

  Show description for aa22bd3
  HenrikJannsen

  committed
  aa22bd3

  Copy full SHA for aa22bd3

• Move validateNodeAddress to DisputeValidation

  Show description for 12686de
  HenrikJannsen

  committed
  12686de

  Copy full SHA for 12686de

• Move validateDonationAddress to DisputeValidation

  Show description for 37457ed
  HenrikJannsen

  committed
  37457ed

  Copy full SHA for 37457ed

• Move testIfAnyDisputeTriedReplay and related methods to DisputeValidation

  Show description for e49e634
  HenrikJannsen

  committed
  e49e634

  Copy full SHA for e49e634

• Part of a multistep refactoring to separate dispute related validation out of TradeDataValidation

  Show description for 2484fa4
  HenrikJannsen

  committed
  2484fa4

  Copy full SHA for 2484fa4

• Remove validateDonationAddress call inside validateDelayedPayoutTx.

  Show description for d86071d
  HenrikJannsen

  committed
  d86071d

  Copy full SHA for d86071d

• Move validateDonationAddress to DisputeValidation

  Show description for cfc67dc
  HenrikJannsen

  committed
  cfc67dc

  Copy full SHA for cfc67dc

• Remove daoFacade as unused parameter

  Show description for e8c6b0a
  HenrikJannsen

  committed
  e8c6b0a

  Copy full SHA for e8c6b0a

• Move null check for address to validateDonationAddress method

  Show description for cfb3780
  HenrikJannsen

  committed
  cfb3780

  Copy full SHA for cfb3780

• Remove dispute field from TradeDataValidation.ValidationException

  Show description for 3007652
  HenrikJannsen

  committed
  3007652

  Copy full SHA for 3007652

• Refactor validateDonationAddress

  Show description for 5daaa60
  HenrikJannsen

  committed
  5daaa60

  Copy full SHA for 5daaa60

• Remove validateDonationAddress method without dispute param

  Show description for 710dba9
  HenrikJannsen

  committed
  710dba9

  Copy full SHA for 710dba9

• Remove addressAsString null check. That was when the donationAddress got added to support not updated nodes. Now there are none of such nodes.

  Show description for 0bf44f0
  HenrikJannsen

  committed
  0bf44f0

  Copy full SHA for 0bf44f0

• Rename to make use case more clear

  Show description for 97648c5
  HenrikJannsen

  committed
  97648c5

  Copy full SHA for 97648c5

• Remove if case for old clients

  Show description for 7f5675f
  HenrikJannsen

  committed
  7f5675f

  Copy full SHA for 7f5675f