API: Fix BSQ buyer's displayed trade fee for gettrade(s) methods #6357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API clients looking at their BSQ swap trades -- BSQ buyers specifically -- were seeing a 0.00 BSQ trade fee, due to an incorrect assumption BSQ sellers paid the entire BSQ trade fee for both sides. BSQ Swap execution via API has been working just like the GUI (same code-base), but the reported trade fee for the BSQ buy side was wrong. This change shows the correct BSQ trade fee. Partially addresses issue bisq-network#6355
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API clients looking at their BSQ swap trades -- BSQ buyers specifically -- were seeing a 0.00 BSQ trade fee, due to an incorrect assumption BSQ sellers paid the entire BSQ trade fee for both sides. BSQ Swap execution via API has been working just like the GUI (same code-base), but the reported trade fee for the BSQ buy side was wrong. This change shows the correct BSQ trade fee.
Partially addresses issue #6355
Based on #6356 and branch
doc-takeoffer-fee-curnency-is-ignored-for-swaps.