Not create and publish account age witnesses for BSQ swap accounts #5974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chimp1984
approved these changes
Jan 18, 2022
core/src/main/java/bisq/core/account/witness/AccountAgeWitnessService.java
Outdated
Show resolved
Hide resolved
bisq-github-admin-3
approved these changes
Jan 20, 2022
ripcurlx
added a commit
that referenced
this pull request
Jan 24, 2022
This is only changed for this release to prevent false positives caused by #5974.
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While creating updated data stores I recognized that the amount of new daily account age witnesses increased by a factor of 10.
The bug was caused as BSQ swap accounts do not extend AssetAccount and are slipping through a re-publish check.