Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include penalty for exceeding transfer limits #5965

Merged
merged 1 commit into from
Jan 24, 2022

Conversation

MwithM
Copy link
Contributor

@MwithM MwithM commented Jan 13, 2022

Nequi payment method did not include that there might be a penalty for exceeding the transfer limits. I have used the same wording for every payment method where it's possible to incur in a penalty for having the trade cancelled because of exceeding transfer limits.

Please @Pazza review.

Nequi payment method did not include that there might be a penalty for exceeding the transfer limits. I have used the same wording for every payment method.
@ripcurlx
Copy link
Contributor

Please pazza @pazza83 review. ☝️

@MwithM pazza != pazza83 😉

@ripcurlx ripcurlx added this to the v1.8.2 milestone Jan 17, 2022
@pazza83
Copy link

pazza83 commented Jan 22, 2022

Hi @MwithM thanks for this.

ACK

@pazza83
Copy link

pazza83 commented Jan 22, 2022

I have used the same wording for every payment method where it's possible to incur in a penalty for having the trade cancelled because of exceeding transfer limits.

Are there other PRs for me to review?

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK - based on #5965 (comment)

@ripcurlx ripcurlx merged commit ded4c07 into bisq-network:master Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants