Rename API method keepfunds -> closetrade (#1) #5951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trade proceeds and deposits have already been transfered to Bisq wallets before the `keepfunds` command is (was) executed; `keepfunds` merely moves open trades to closed trades lists and persistence files. Renaming `keepfunds` as `closetrade` makes its purpose clear to API users. The commit modifies only method names and comments in api server+cli classes, apitest cases, and api trade simulation scripts. Based on `master`
ghubstan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trade proceeds and deposits have already been transferred to Bisq wallets before the
keepfundscommand is (was) executed;keepfundsmerely moves open trade to closed trade lists and persistence files. Renamingkeepfundsasclosetrademakes its purpose clear to API users.The commit modifies only method names and comments in api server+cli classes, apitest cases, and api trade simulation scripts.
Based on
master