Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix API CLI's '--payment-account-id' opt name, document 'createcryptopaymentacct' (#8) #5939

Merged
merged 5 commits into from
Jan 3, 2022

Conversation

ghubstan
Copy link
Contributor

Rename CLI opt '--payment-account' -> '--payment-account-id'.
Resolves #5893 (comment).

Document 'createcryptopaymentacct' in API beta-test guide
Resolves #5893 (comment).

Based on #5938

The method 'getoffer' should support looking up a user's open-offers, and other users' available offers.

- Adjust api-beta-test-guide.md to use only 'getoffer'.
- Adjust trade simulation scripts to use only 'getoffer'.
- Adjust api testcases to use 'getoffer' in place of 'getmyoffer'.
- Mark appropriate methods and protobuf msgs as deprecated.
@ghubstan ghubstan changed the title Fix API CLI's '--payment-account-id' opt name, document 'createcryptopaymentacct' Fix API CLI's '--payment-account-id' opt name, document 'createcryptopaymentacct' (#8) Dec 27, 2021
@ripcurlx
Copy link
Contributor

@ghubstan Please resolve the conflicts and I'll test it afterwards. Thanks!

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK - code changes are looking fine

@ripcurlx ripcurlx added this to the v1.8.1 milestone Jan 3, 2022
@ripcurlx ripcurlx merged commit bb68ff0 into bisq-network:master Jan 3, 2022
@ghubstan ghubstan deleted the 8-api-payment-acct-opt-n-doc branch January 3, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants