Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API XMR/BTC trading pair support (#6) #5893

Merged
merged 19 commits into from
Dec 29, 2021
Merged

API XMR/BTC trading pair support (#6) #5893

merged 19 commits into from
Dec 29, 2021

Commits on Dec 1, 2021

  1. Use calculated offer maker fee, do not re-calculate it

    @ghubstan
    ghubstan committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    d57d6e9 View commit details
    Browse the repository at this point in the history

  2. Use offer instance to determine ownership, not it's id

    @ghubstan
    ghubstan committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    e3c4089 View commit details
    Browse the repository at this point in the history

  3. Calculate offer.makerFee if offer is bsq-swap 

    V1 offer instances have a makeFee value, but not BSQ swap offers.
This needs to be investigated.
See commit d57d6e9.
    @ghubstan
    ghubstan committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    33d976c View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2021

  1. Add more readable toString method to MutableOfferPayloadFields 

    This makes it easier to compare to EditOfferValidator.toString
    @ghubstan
    ghubstan committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    095a495 View commit details
    Browse the repository at this point in the history

  2. Refactor api.core side editoffer validation & fix bug 

    The editoffer validation bug fixes:

- A trigger-price edit forced offer.price-margin=0.00.

	This needs to be checked in new apitest case asserts.

- An activate state (only) edit forced offer.isUseMarketBasedPrice=true.

	The CLI does not have the offer instance, and cannot know the correct
	value of the isUseMarketBasedPrice param sent in the editoffer request.
	The daemon has to figure this out.  If the editType parameter value
	sent to daemon is ACTIVATION_STATE_ONLY, use the current offer.isUseMarketBasedPrice.

The refactoring includes more useful and readable information in core's EditOfferValidator
and MutableOfferPayloadFields toString methods, for debugging with the daemon log. And some
adjustments for allowing edits to XMR offers.
    @ghubstan
    ghubstan committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    b85459d View commit details
    Browse the repository at this point in the history

  3. Adjust API CorePaymentAccountsService for creating XMR accts

    @ghubstan
    ghubstan committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    ce8b6df View commit details
    Browse the repository at this point in the history

  4. Allow mkt price lookup for any altcoin from API

    @ghubstan
    ghubstan committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    742a6f4 View commit details
    Browse the repository at this point in the history

  5. Adjust API cli-side CryptoCurrencyUtil & OffersServiceRequest for XMR… 

    … support
    @ghubstan
    ghubstan committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    54f815e View commit details
    Browse the repository at this point in the history

  6. Make altcoin offer sorting method names more generic

    @ghubstan
    ghubstan committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    03b5791 View commit details
    Browse the repository at this point in the history

  7. Adjust CLI opts parsers & opt parsing test for XMR support

    @ghubstan
    ghubstan committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    a45c5fa View commit details
    Browse the repository at this point in the history

  8. Test API XMR support

    @ghubstan
    ghubstan committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    743ef93 View commit details
    Browse the repository at this point in the history

  9. Add CliMain.main(args) tests 

    There are no asserts, but helpful for looking at affects of CLI commands
from terminal because apitest cases use gRPC service stubs instead of terminal.
    @ghubstan
    ghubstan committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    65fb8e8 View commit details
    Browse the repository at this point in the history

  10. Add new regtest apitest/scripts/trade-xmr-simulation.sh

    @ghubstan
    ghubstan committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    f867f6b View commit details
    Browse the repository at this point in the history

  11. Add a few more checks on editedOffer.getUseMarketBasedPrice()

    @ghubstan
    ghubstan committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    e2647af View commit details
    Browse the repository at this point in the history

  12. Do not run 2x from gradle terminal cmd 

    Method tests are combined in scenario pkg tests to reduce test
harness startup/shutdown time.
    @ghubstan
    ghubstan committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    104f11a View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2021

  1. Merge branch '5-api-bsqswap-simulation-n-docs-update' into 6-api-xmr-… 

    …trading
    @ghubstan
    ghubstan committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    0f32fe2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into 6-api-xmr-trading

    @ghubstan
    ghubstan committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    5f7fd62 View commit details
    Browse the repository at this point in the history

  3. Use string in BigDecimal ctor, and make codacy happy too

    @ghubstan
    ghubstan committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    98b41cb View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2021

  1. Merge branch 'master' into 6-api-xmr-trading

    @ghubstan
    ghubstan authored Dec 15, 2021
    Configuration menu
    Copy the full SHA
    705e34e View commit details
    Browse the repository at this point in the history