-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API BSQ swap simulation script and doc updates #5 #5876
API BSQ swap simulation script and doc updates #5 #5876
Commits on Nov 11, 2021
-
Adjust bsq-swap-offer related gRPC services & msgs
- Adjust GetBsqSwapOffer(s) rpc services to remove currency param. - Adjust OfferInfo and remove BsqSwapOfferInfo. - Add GetOfferCategory service so CLI can determine what kind of takeoffer service is to be used. - Add comment about adding sub-message BsqSwapTradeInfo field to TradeInfo.
Configuration menu - View commit details
-
Copy full SHA for 5924312 - Browse repository at this point
Copy the full SHA 5924312View commit details -
Adjust bsq-swap-offer related gRPC daemon services
- Add GetOfferCategory service so CLI can determine what kind of takeoffer service is to be used. - Adjust to removal of BsqSwapOfferInfo proto. - Call new coreApi.getRole(BsqSwapTrade) before building BsqSwapTradeInfo proto.
Configuration menu - View commit details
-
Copy full SHA for c6aceb0 - Browse repository at this point
Copy the full SHA c6aceb0View commit details -
Partially adjust api proto wrappers for bsq-swap support
- Complete BsqSwapTradeInfo impl. - Merge BsqSwapOfferInfo fields into OfferInfo and remove BsqSwapOfferInfo. - Change all model builders to private static class Builder.
Configuration menu - View commit details
-
Copy full SHA for 5d63fd7 - Browse repository at this point
Copy the full SHA 5d63fd7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 713b309 - Browse repository at this point
Copy the full SHA 713b309View commit details -
Configuration menu - View commit details
-
Copy full SHA for 521495c - Browse repository at this point
Copy the full SHA 521495cView commit details -
Partially adjust core api for bsq-swap support
- Add core api methods to help CLI determine which type of offer to take for a given offerId. CLI's 'takeoffer` will need to determine which gRPC/proto request type to send to server. - Add implemetations for getBsqSwapTradeRole(), for tradeId or trade.
Configuration menu - View commit details
-
Copy full SHA for 3dfbf3f - Browse repository at this point
Copy the full SHA 3dfbf3fView commit details -
Paritally adjust bsq-swap-offer related gRPC CLI side classes
- Adjust to removal of BsqSwapOfferInfo proto, use ammended OfferInfo instead. - Remove currency-code param from all get(My)BsqSwapOffer(s) requests. - Add new OfferCategory getAvailableOfferCategory(String offerId) service. CLI uses this to determine which kind of gRPC request object should be sent with a 'takeoffer' request. - Adjust GetOffersSmokeTest to help see offer/swap-offer CLI output.
Configuration menu - View commit details
-
Copy full SHA for 16be357 - Browse repository at this point
Copy the full SHA 16be357View commit details -
Paritally adjust bsq-swap-offer related apitest cases
- Adjust to removal of BsqSwapOfferInfo proto, use ammended OfferInfo instead. - Remove currency-code param from all get(My)BsqSwapOffer(s) requests.
Configuration menu - View commit details
-
Copy full SHA for c5f50b5 - Browse repository at this point
Copy the full SHA c5f50b5View commit details
Commits on Nov 12, 2021
-
Normalize API gRPC bsq-swap related protos & wrappers
This commit refactors the first cut of the BsqSwapTradeInfo and TradeInfo gRPC proto defs and wrappers. The change avoids duplication of fields between BsqSwapTradeInfo and TradeInfo, and adds a bsqSwapTradeInfo field to the old TradeInfo proto & wrapper. The immediate goal is moving towards getting the API's 'gettrade' method to work for both Bisq v1 trades and BSQ swap trades: the TradeInfo proto sent to the CLI should represent either a Bisq v1 trade or a BSQ swap trade. A mid-term term goal is to also make a new 'gettrades' method return a List<TradeInfo> to the CLI, where items in the List<TradeInfo> can be either v1 trades or bsq-swap trades.
Configuration menu - View commit details
-
Copy full SHA for 564303a - Browse repository at this point
Copy the full SHA 564303aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f01279 - Browse repository at this point
Copy the full SHA 9f01279View commit details
Commits on Nov 14, 2021
-
Configuration menu - View commit details
-
Copy full SHA for fc53ca4 - Browse repository at this point
Copy the full SHA fc53ca4View commit details -
Adjust API 'gettrade' for Bsq swaps
- Made several adjustments to CLI's 'gettrade' output related code so it can show single trade details for either Bisq v1 trades, or BSQ swap trades. - Did minor refactoring of API's core to retrieve # tx confirmations for an addresses and transactions. - Show # of tx confirmations in bsq swap trade detail.
Configuration menu - View commit details
-
Copy full SHA for 4ca878a - Browse repository at this point
Copy the full SHA 4ca878aView commit details -
Configuration menu - View commit details
-
Copy full SHA for d8f1e44 - Browse repository at this point
Copy the full SHA d8f1e44View commit details
Commits on Nov 23, 2021
-
Configuration menu - View commit details
-
Copy full SHA for b65cc9c - Browse repository at this point
Copy the full SHA b65cc9cView commit details
Commits on Nov 24, 2021
-
Remove Get/Take BSQSwap Offer/Trade rpc service defs
The old GetTrade and TakeOffer rpc service defs will be used for getting BSQ swap trades, and taking BSQ swap offers.
Configuration menu - View commit details
-
Copy full SHA for 17277c4 - Browse repository at this point
Copy the full SHA 17277c4View commit details -
Refactor GrpcTradesService: use GetTrade & TakeOffer services for BSQ…
… swaps The rpc GetBsqSwapTrade and TakeBsqSwapOffer services were a quick hack to help test BSQ swap feature development more quickly, using apitest cases. Their gRPC service method implementations are removed here and the GetTrade & TakeOffer service methods are refactored to support BSQ swaps.
Configuration menu - View commit details
-
Copy full SHA for f88c151 - Browse repository at this point
Copy the full SHA f88c151View commit details -
Refactor core.api trade service implemenentations for BSQ swaps
A minor refactoring to support serving TradeModel instances to CLI. For example, the CLI 'gettrade' command must return a v1 Trade or BSQ swap trade.
Configuration menu - View commit details
-
Copy full SHA for 3aae052 - Browse repository at this point
Copy the full SHA 3aae052View commit details -
Adjust CLI to support getting/taking BSQ swaps
Also refactored some of the opt parsers.
Configuration menu - View commit details
-
Copy full SHA for 0c5c343 - Browse repository at this point
Copy the full SHA 0c5c343View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6403fc1 - Browse repository at this point
Copy the full SHA 6403fc1View commit details -
Configuration menu - View commit details
-
Copy full SHA for c177b3b - Browse repository at this point
Copy the full SHA c177b3bView commit details
Commits on Nov 25, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 00a5e2b - Browse repository at this point
Copy the full SHA 00a5e2bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3077be5 - Browse repository at this point
Copy the full SHA 3077be5View commit details -
Configuration menu - View commit details
-
Copy full SHA for b1c872c - Browse repository at this point
Copy the full SHA b1c872cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 35aeb61 - Browse repository at this point
Copy the full SHA 35aeb61View commit details -
Configuration menu - View commit details
-
Copy full SHA for eff1084 - Browse repository at this point
Copy the full SHA eff1084View commit details -
Configuration menu - View commit details
-
Copy full SHA for 15621d4 - Browse repository at this point
Copy the full SHA 15621d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 132ecc9 - Browse repository at this point
Copy the full SHA 132ecc9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0aa0852 - Browse repository at this point
Copy the full SHA 0aa0852View commit details
Commits on Nov 26, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 05d1916 - Browse repository at this point
Copy the full SHA 05d1916View commit details
Commits on Nov 27, 2021
-
Make rpc GetOfferCategory service work for my+avail offers
There are some use cases where the CLI needs to know what kind of offer is being acted on before the request is made, For example: There are differences between a BsqSwap 'takeoffer'request, and a v1 'takeoffer' request. A BsqSwap offer cannot be edited by an 'editoffer' request, and an attempt should be blocked by the CLI. - Append isMyOffer GetOfferCategoryRequest rpc msg def. - Adjust daemon.grpc services for new boolean GetOfferCategoryRequest param. - Adjust core.api for new boolean GetOfferCategoryRequest param. - Add validation check in core.api EditOfferValidator to block attempt to edit a BsqSwap offer. - Refactor CoreOffersService get*offer(id) methods to optionally throw excpetions.
Configuration menu - View commit details
-
Copy full SHA for 64f228d - Browse repository at this point
Copy the full SHA 64f228dView commit details -
Configuration menu - View commit details
-
Copy full SHA for b95e4b3 - Browse repository at this point
Copy the full SHA b95e4b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 000fe9b - Browse repository at this point
Copy the full SHA 000fe9bView commit details -
There is no --swap opt in editoffer command
BSQ swap offers cannot be edited
Configuration menu - View commit details
-
Copy full SHA for b5981b5 - Browse repository at this point
Copy the full SHA b5981b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d8559d - Browse repository at this point
Copy the full SHA 0d8559dView commit details
Commits on Nov 28, 2021
-
Revert "There is no --swap opt in editoffer command"
This reverts commit b5981b5. This was a mistake. There is a swap opt in the createoffer command.
Configuration menu - View commit details
-
Copy full SHA for 66115f3 - Browse repository at this point
Copy the full SHA 66115f3View commit details -
Add apitest/scripts/bsqswap-simulation.sh script
Some refactoring and typo corrections in existing scripts too.
Configuration menu - View commit details
-
Copy full SHA for 1b7e43a - Browse repository at this point
Copy the full SHA 1b7e43aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b2dec7 - Browse repository at this point
Copy the full SHA 8b2dec7View commit details
Commits on Nov 29, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 6b89254 - Browse repository at this point
Copy the full SHA 6b89254View commit details -
Allow unrecognized options in OfferIdOptionParser where appropriate
The OfferIdOptionParser superclass reduces duplication for parsing offer-id parameters, but it needs to let subclass parsers' other options pass validation.
Configuration menu - View commit details
-
Copy full SHA for b1dd205 - Browse repository at this point
Copy the full SHA b1dd205View commit details -
Update API docs for Bitcoin Core version v22.0
Plus some outdated JDK version compat comments.
Configuration menu - View commit details
-
Copy full SHA for a1db0d1 - Browse repository at this point
Copy the full SHA a1db0d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3015554 - Browse repository at this point
Copy the full SHA 3015554View commit details
Commits on Nov 30, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 946ca46 - Browse repository at this point
Copy the full SHA 946ca46View commit details
Commits on Dec 3, 2021
-
Add missing --currency-code=bsq param to createoffer example
Resolves issue mentioned in bisq-network#5876 (review)
Configuration menu - View commit details
-
Copy full SHA for bb68605 - Browse repository at this point
Copy the full SHA bb68605View commit details -
Tell user bsqswap offer cannot be edited, but can be canceled at no c…
…harge Resolves issue described in bisq-network#5876 (review)
Configuration menu - View commit details
-
Copy full SHA for f195b76 - Browse repository at this point
Copy the full SHA f195b76View commit details