Improve TradeStatistics validation #5853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
found in the active list. Otherwise the 2 BTC default is used. We get TradeStatistics3 objects from old retired PaymentMethods which are not found in the active list.
ghubstan
reviewed
Nov 22, 2021
core/src/main/java/bisq/core/trade/statistics/TradeStatistics3.java
Outdated
Show resolved
Hide resolved
ghubstan
reviewed
Nov 22, 2021
ghubstan
reviewed
Nov 23, 2021
core/src/main/java/bisq/core/trade/statistics/TradeStatistics3.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only apply maxTradeLimit from PaymentMethod if the PaymentMethod is found in the active list. Otherwise the 2 BTC default is used.
We get TradeStatistics3 objects from old retired PaymentMethods
which are not found in the active list.