Bug fixes: Locked Balance display; Portfolio History screen

[ghost]

2 bugfixes for 1.8.0:

Locked Balance display

Since #5813, the timing when a new trade affects locked balance display is slightly different, so now we need to update the UI when a new block is published. (Until now was only updated when the trade and offer collections changed size).

Portfolio History screen

To reproduce the problem: your portfolio history contains a canceled offer that was made with a different onion address. This can be quite common if you have changed your onion address. Its a similar problem as previously found in #5358

Details

 

Nov-18 16:55:36.129 [JavaFX Application Thread] ERROR bisq.common.setup.CommonSetup: Uncaught Exception from thread JavaFX Application Thread 
Nov-18 16:55:36.130 [JavaFX Application Thread] ERROR bisq.common.setup.CommonSetup: throwableMessage= class bisq.core.offer.OpenOffer cannot be cast to class bisq.core.trade.model.bisq_v1.Trade (bisq.core.offer.OpenOffer and bisq.core.trade.model.bisq_v1.Trade are in unnamed module of loader 'app') 
Nov-18 16:55:36.130 [JavaFX Application Thread] ERROR bisq.common.setup.CommonSetup: throwableClass= class java.lang.ClassCastException 
Nov-18 16:55:36.134 [JavaFX Application Thread] ERROR bisq.common.setup.CommonSetup: Stack trace:
java.lang.ClassCastException: class bisq.core.offer.OpenOffer cannot be cast to class bisq.core.trade.model.bisq_v1.Trade (bisq.core.offer.OpenOffer and bisq.core.trade.model.bisq_v1.Trade are in unnamed module of loader 'app')
	at bisq.core.trade.ClosedTradableUtil.castToTrade(ClosedTradableUtil.java:75)
	at bisq.core.trade.ClosedTradableManager.isBsqTradeFee(ClosedTradableManager.java:219)
	at bisq.core.trade.ClosedTradableFormatter.getTradeFeeAsString(ClosedTradableFormatter.java:124)
	at bisq.desktop.main.portfolio.closedtrades.ClosedTradesViewModel.getTradeFee(ClosedTradesViewModel.java:75)
	at bisq.desktop.main.portfolio.closedtrades.ClosedTradesView$12$1.updateItem(ClosedTradesView.java:743)
	at bisq.desktop.main.portfolio.closedtrades.ClosedTradesView$12$1.updateItem(ClosedTradesView.java:739)
	at javafx.scene.control.TableCell.updateItem(TableCell.java:665)

---

Solution: try/catch/handle the ClassCastException.

[ripcurlx]

@jmacxx Please have a look at the broken test mentioned here https://github.com/bisq-network/bisq/runs/4268685330?check_suite_focus=true. Thanks!

[ghost]

Something went wrong with the git history at the second commit, I've redone it and should be ok now.

[ripcurlx]

utACK