-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve japanese bank branch validation #5694
Improve japanese bank branch validation #5694
Conversation
The diff is so big I have no idea what you actually changed... |
I think you should probably only change the bottom part of the file where the regex patterns actually changed, otherwise you're rewriting the entire code |
Did you look at the commits 😉. I've put the formatting fixes in a separate commit and the other two changes in two further commits. So it is easy to see what actually changed. |
What's significant is the 2nd commit c781394. It's so simple, no regression seems possible. The 3rd commit 4d62136 is even more trivial, like just improving comments. The 1st commit 851ef07 is less transparent, but after hiding whitespace changes, I see there are only 2 actual edits:
I guess 1 is simply unused "include"s, and 2 is something like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formatting and style changes are good. I cannot tell if the regex changes are good but from @wiz and @Liisachan they sound correct.
utACK |
Fixes #5688