[WIP (redo after atomic-tx merge)] Create XMR <-> BTC offers via API #5690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some i18n property values can be used by the API if long strings are wrapped before written as commments to json payment account forms, or written to the CLI console. This change anticipates the addition of the more complex Swift payment method (PR 5672). PR 5672's i18n property value for key "payment.swift.info" will be wrapped and appended to the comments of the Swift payment account's json form.
Several payment methods support multiple trade currencies and a selected trade currency, but the api's payment account creation has not let CLI users specify them in the json form passed to the `createpaymentacct` command. This change adds `tradeCurrencies` and `selectedTradeCurrency` fields to the appropriate json forms.
Define and verify trade currencies and selected trade currency values in appropriate api test cases, and add test cases for new payment methods.
Method was added on the false assumption `PaymentAccount#hasMultipleCurrencies()` would not always return a correct value when a `PaymentAccount` instance is created via reflection. But `hasMultipleCurrencies()` will work as long as appropriate PaymentAccount subclasses continue setting their `tradeCurrencies` fields within their default constructors.
So we can see all fields (especially address) -- not always shown by annotation generated toString.
Note that newest Intellij code auto-formatter has improved indentation of method parameters on separate lines.
As usual, method pkg tests are disabled to reduce gradle apitest case runtimes. Method pkg tests are run from bisq.apitest.scenario test cases to reduce # of time test harness setup/shutdown is run.
ghubstan
changed the title
|
Additional work required to support margin based price offers (not just fixed price offers, like BSQ). |
ghubstan
changed the title
ghubstan
changed the title
|
Need to hold off on review until XMR |
ghubstan
changed the title
ghubstan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createofferhelp text.Note: Intellij improved its auto code formatting, resulting in some indentation changes in some of this PRs commits.
This is the 3rd in a series of PRs starting with #5685.
#5687 should be reviewed & merged before this one.