Add bitcoinj Tor v3 support #5686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f578f427d78242bc2) Conflicts: build.gradle gradle/witness/gradle-witness.gradle
|
@jmacxx Could you also give this bitcoinj version a spin? |
|
tested ACK |
|
@sqrrm Could you please ACK and merge this PR as well so I can create the release branch for v1.7.4? |
@Emzy Could you please provide a PR with the Tor v3 addresses for the v1.7.4 release? Thanks! |
There are still some v3 onions from nodes missing. I'm on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is atm only for those who want to help with testing our new bitcoinj fork on Regtest. If you want to test Tor v3 addresses against Mainnet only do it with a fresh data directory and DO NOT try to use it for real transactions as we haven't done intensive testing yet (only automated Regtest testing)
If you need a Bitcoin Core Node Tor v3 address for testing you can use mine (this is one of the federated Bitcoin core ndoes):
catlnkpdm454ecngktyo4z22m5dlcvfvgzz4nt5l36eeczecrafslkqd.onione.g. use
--btcNodes=catlnkpdm454ecngktyo4z22m5dlcvfvgzz4nt5l36eeczecrafslkqd.onionas startup argument.Afterwards you should see following in your Network Info Tab