Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community tab #5680

Merged
merged 4 commits into from Sep 27, 2021
Merged

Community tab #5680

merged 4 commits into from Sep 27, 2021

Conversation

ghost
Copy link

@ghost ghost commented Aug 30, 2021

Fixes #4904

@ghost ghost changed the title [WIP] Community tab Community tab Sep 8, 2021
@ripcurlx
Copy link
Contributor

@xyzmaker123 Thanks for your PR. Just a couple of remarks on the UI Code. Please try to use the AutoTooltip... components instead of the JFX.. default ones. So it will automatic truncate and provide a tooltip if a translation won't fit into the boundaries. The other thing is we try to not use FXML syntax whenever possible as it is bad for performance. So we normally just have a main container as an entry point and instantiate all other UI components manually. And yes, there are still some legacy FXML UIs (network..) out there which would need some dev love. 😉

@ghost
Copy link
Author

ghost commented Sep 15, 2021

@ripcurlx Thank you for your comments - I updated pull request in accordance with them.

@ghost ghost mentioned this pull request Sep 19, 2021
@ripcurlx ripcurlx added this to the v1.7.5 milestone Sep 23, 2021
@ripcurlx
Copy link
Contributor

@xyzmaker123 All your new views are missing the license header.

@ripcurlx
Copy link
Contributor

@xyzmaker123 All your new views are missing the license header.

Not all - just the *View.java ones

@ripcurlx
Copy link
Contributor

ripcurlx commented Sep 27, 2021

I think the biggest issue this has is that it will truncate the menu bar even for English in the default width of 1200. To make this work for an initial startup we need to adapt Layout.INITIAL_WINDOW_WIDTH to 1240. This probably shouldn't be a big deal for most screens IMO.

Bildschirmfoto 2021-09-27 um 10 29 06

Bildschirmfoto 2021-09-27 um 10 46 50

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK - Please review my comments, but I fixed the issues myself already.

@ripcurlx ripcurlx merged commit b098656 into bisq-network:master Sep 27, 2021
@ghost
Copy link
Author

ghost commented Sep 28, 2021

Thanks @ripcurlx for final fixes. Yeah - I'll try to be more careful about license header in future.

@chimp1984
Copy link
Contributor

Added an issue: #5732

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Promote Keybase as a support channel within Bisq GUI
2 participants