-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Community tab #5680
Community tab #5680
Conversation
@xyzmaker123 Thanks for your PR. Just a couple of remarks on the UI Code. Please try to use the AutoTooltip... components instead of the JFX.. default ones. So it will automatic truncate and provide a tooltip if a translation won't fit into the boundaries. The other thing is we try to not use FXML syntax whenever possible as it is bad for performance. So we normally just have a main container as an entry point and instantiate all other UI components manually. And yes, there are still some legacy FXML UIs (network..) out there which would need some dev love. 😉 |
@ripcurlx Thank you for your comments - I updated pull request in accordance with them. |
@xyzmaker123 All your new views are missing the license header. |
Not all - just the *View.java ones |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK - Please review my comments, but I fixed the issues myself already.
Thanks @ripcurlx for final fixes. Yeah - I'll try to be more careful about license header in future. |
Added an issue: #5732 |
Fixes #4904