-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new api method 'editoffer' #5572
Conversation
- Define set of editable offer payload fields in MutableOfferPayloadFields. - Move bulk of EditOfferDataModel#onPublishOffer logic to OfferUtil.
- Add editOffer to GrpcOffersService, CoreApi, CoreOffersService. - Set editOffer call rate meter to 1 / minute. - Use new EditOfferValidator to verify editOffer params OK. - Adust getMyOffer(s) rpc impl and OfferInfo model to use OpenOffer for accessing activation state and trigger price.
Reduces size of GrpcClient while allowing for additional bot-friendly variations of the new grpc editOffer method.
TODO in next PR: Update api beta test guide and trading simulation script. |
This codacy issue should be ignored because an apparent IDE bug will not allow me to use only
|
Support for editing BSQ offers is in place, but will be added in another PR.
I ignored the issue. Could you please try to force push again to re-trigger codacy? Thanks! |
This TODO was to tell me what goes in the next PR. |
File conflicts resolved in child PR #5666 |
To help review from bottom to top, commits are listed here in bottom to top order.
1daf471 Add
OfferInfo
fieldisActivated
, rpcEditOffer
togrpc.proto
2b8b53b Add server/core
editOffer
, adjustgetMyOffer(s)
implsAdd
editOffer
toGrpcOffersService
,CoreApi
,CoreOffersService
.Set
editOffer
call rate meter to 1 / minute.Use new
EditOfferValidator
to verifyeditOffer
params OK.Adust
getMyOffer(s)
rpc impl andOfferInfo
model to useOpenOffer
for accessing activation state and trigger price.9231e48 Refactor GrpcClient: request building code moved into
bisq.cli.request
pkgReduces size of
GrpcClient
while allowing for new, bot-friendly variations of the new grpc.editOffer method. (Various combinations ofeditoffer
parameters are allowed and disallowed; the bot-friendly grpc.editOffer variations help disambiguate those parameter combinations.)d2939cc Add new
EditOfferOptionParser
& test2344285 Add
editoffer
method helpbe249c5 Add
editoffer
to CLI929b28c Add
editoffer
api tests & minor apitest refactoringThis is the 3rd in a series of PRs, starting at #5570
#5571 Should be reviewed/merged before this one.
The new
editoffer
method works, and is documented ineditoffer-help.txt
, but some follow up work is needed.Next PR(s) will be:
getmyoffer(s)
CLI output for new 'enabled
' and 'trigger-price
' columns.getmyoffer(s)
CLI output.editoffer
, and to newgetmyoffer(s)
CLI output.