Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip for unsigned accounts needs to provide more information #5569

Closed
wants to merge 5 commits into from
Closed

Tooltip for unsigned accounts needs to provide more information #5569

wants to merge 5 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 11, 2021

Fixes #4416

Copy link

@kaiwolfram kaiwolfram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can open draft pull requests for something that is work in progress

@ghost ghost marked this pull request as draft June 13, 2021 17:14
@ghost ghost changed the title [WIP] Tooltip for unsigned accounts needs to provide more information Tooltip for unsigned accounts needs to provide more information Jun 20, 2021
@ghost ghost marked this pull request as ready for review June 20, 2021 10:23
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK - Please see my comments.

Additionally I recognized following issues:

Bildschirmfoto 2021-06-22 um 17 02 13

  • Based on the designs by @pedromvpg the title should be bold.
  • Right now it is not possible to click on the learn more link as it is hidden as soon as you try to hover over the tooltip.
  • It would be great to add the suggestion by @pedromvpg Also the user should be told how many days are left after the first signing. as well.

Bildschirmfoto 2021-06-22 um 17 12 55

It would be good to use the same tooltip in the accounts section as well.

Besides that everything is looking promising 😄

@ghost
Copy link
Author

ghost commented Jun 26, 2021

@ripcurlx

  • I have trouble with making title bold - I've tried: titleLabel.getStyleClass().add("bold-text"); and titleLabel.setStyle("-fx-font-weight: bold !important;"); but none of these worked - I've spent a lot of time debugging it, but I'm tired of it :( Do you have idea why it doesn't work?
  • Regarding learn more link - currently popup disappear after mouseleave on icon - should I change it? How it should works?

@ripcurlx
Copy link
Contributor

  • I have trouble with making title bold - I've tried: titleLabel.getStyleClass().add("bold-text"); and titleLabel.setStyle("-fx-font-weight: bold !important;"); but none of these worked - I've spent a lot of time debugging it, but I'm tired of it :( Do you have idea why it doesn't work?

I can have a look at it - JavaFX CSS is sometimes a little bit tricky.

  • Regarding learn more link - currently popup disappear after mouseleave on icon - should I change it? How it should works?

I think for this kind of popover you'd need to change the behavior, that it doesn't close so quickly and that you keep it open when the mouse hovers over the tooltip. I think the intention is, that if someone wants to know more she should be able to click the "learn more" link 😉

@ripcurlx
Copy link
Contributor

As I had problems because of git lfs to push to this branch I had to create my own PR so it is superseded by #5625.

@ripcurlx ripcurlx closed this Jul 16, 2021
@ghost ghost mentioned this pull request Aug 28, 2021
@ghost ghost deleted the unsigned-account-tooltip branch December 20, 2021 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip for unsigned accounts needs to provide more information
2 participants