-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tooltip for unsigned accounts needs to provide more information #5569
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can open draft pull requests for something that is work in progress
desktop/src/main/java/bisq/desktop/components/InfoAutoTooltipLabel.java
Outdated
Show resolved
Hide resolved
desktop/src/main/java/bisq/desktop/components/InfoAutoTooltipLabel.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NACK - Please see my comments.
Additionally I recognized following issues:
- Based on the designs by @pedromvpg the title should be bold.
- Right now it is not possible to click on the learn more link as it is hidden as soon as you try to hover over the tooltip.
- It would be great to add the suggestion by @pedromvpg
Also the user should be told how many days are left after the first signing.
as well.
It would be good to use the same tooltip in the accounts section as well.
Besides that everything is looking promising 😄
desktop/src/main/java/bisq/desktop/components/AccountStatusTooltipLabel.java
Outdated
Show resolved
Hide resolved
desktop/src/main/java/bisq/desktop/components/AccountStatusTooltipLabel.java
Outdated
Show resolved
Hide resolved
…ltipLabel.java Co-authored-by: Christoph Atteneder <[email protected]>
…ltipLabel.java Co-authored-by: Christoph Atteneder <[email protected]>
Co-authored-by: Christoph Atteneder <[email protected]>
|
I can have a look at it - JavaFX CSS is sometimes a little bit tricky.
I think for this kind of popover you'd need to change the behavior, that it doesn't close so quickly and that you keep it open when the mouse hovers over the tooltip. I think the intention is, that if someone wants to know more she should be able to click the "learn more" link 😉 |
As I had problems because of git lfs to push to this branch I had to create my own PR so it is superseded by #5625. |
Fixes #4416