Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect tx link to tx explorer - fixes #5548 #5563

Merged
merged 4 commits into from Jun 22, 2021
Merged

Fix incorrect tx link to tx explorer - fixes #5548 #5563

merged 4 commits into from Jun 22, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jun 10, 2021

Fixes #5548

@boring-cyborg
Copy link

boring-cyborg bot commented Jun 10, 2021

Thanks for opening this pull request!

Please check out our contributor checklist and check if Travis or Codacy found any issues with your PR. Also make sure your commits are signed, and that you applied Bisq's code style and formatting.

A maintainer will add an is:priority label to your PR if it is up for compensation. Please see our Bisq Q1 2020 Update post for more details.

kaiwolfram
kaiwolfram reviewed Jun 10, 2021
View reviewed changes
Copy link

@kaiwolfram kaiwolfram left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK

TxIdTextField shouldnt be responsible for opening address URLs

desktop/src/main/java/bisq/desktop/components/TxIdTextField.java Outdated Show resolved Hide resolved
desktop/src/main/java/bisq/desktop/main/overlays/windows/ContractWindow.java Outdated Show resolved Hide resolved
desktop/src/main/java/bisq/desktop/components/TxIdTextField.java Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Jun 11, 2021

In accordance to comments by @KaiWitt I prepared alternative solution with new ExplorerAddressTextField instead of modifying TxIdTextField

@ghost ghost requested a review from ripcurlx June 17, 2021 19:00
ripcurlx
ripcurlx approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK - Tested it on RegTest and it works as expected

@ripcurlx ripcurlx merged commit 6ab5cec into bisq-network:master Jun 22, 2021
@ripcurlx ripcurlx added this to the v1.6.6 milestone Jun 22, 2021
@ghost ghost mentioned this pull request Aug 28, 2021
Closed
@ghost ghost deleted the open-address-explorer branch December 20, 2021 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.

Incorrect tx link to tx explorer
2 participants
@ripcurlx @kaiwolfram