Add fiat equivalent for Total Amount & Security Deposit for both makers and sellers #5452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BtcContributor I just started with release testing and recognized that for BSQ the fiat amount is not displayed as described above. Please see |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the recap of the trade displays also the fiat equivalent for Total Amount & Security Deposit for both makers and sellers.
Fix also the Total Amount displayed as a taker of a Sell btc trade when using bsq as trading fees (Bsq was not displayed in Total Amount).
Maker, btc trading fee, previously
Maker, btc trading fee, now
Taker, btc trading fee, previously
Taker, btc trading fee, now
Maker, bsq trading fee, previously
Maker, bsq trading fee, now
Taker, bsq trading fee, previously -> THIS IS INCORRECT AS BSQ TRADING FEES ARE NOT DISPLAYED IN TOTAL AMOUNT
Taker, bsq trading fee, now
When security deposit is not the minimum for example, this is how it looks like: