Fix bsq wallet & tx fee rate test cases (api) #5447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regtest btc block was not being generated, and chain download not triggered. Also ajusted testGetUnusedBsqAddress() for upcoming segwit bsq changes.
Min tx fee rates move fast, sometimes so low the validation test fails. Try to consistently force validation error by setting fee rate=1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BsqWalletTestRegtest btc block being generated with this fix, and chain download triggered. Also adjusted testGetUnusedBsqAddress() for upcoming SegWit BSQ changes.BtcTxFeeRateTestMinimum tx fee rates move fast, sometimes so low the validation test fails. This change tries to consistently force validation error by setting fee rate=1.